Skip to content

Replace css shadow border link underline hack with text-decoration-skip: ink #797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 9, 2017
Merged

Replace css shadow border link underline hack with text-decoration-skip: ink #797

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion assets/less/content/footer.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,6 @@

a {
color: @mediumGray;
.linkUnderlines(@white, @mediumGray)
.linkUnderlines(@mediumGray)
}
}
2 changes: 1 addition & 1 deletion assets/less/content/general.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ h3 {
}

a {
.linkUnderlines(@white, @black);
.linkUnderlines(@black);
}

a.no-underline {
Expand Down
33 changes: 4 additions & 29 deletions assets/less/mixins.less
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,33 +1,8 @@
@selectionColor: #b4d5fe;

.textShadowToCropUnderline(@color) {
text-shadow: .03em 0 @color, -.03em 0 @color, 0 .03em @color, 0 -.03em @color, .06em 0 @color, -.06em 0 @color, .09em 0 @color, -.09em 0 @color, .12em 0 @color, -.12em 0 @color, .15em 0 @color, -.15em 0 @color;
}

.linkUnderlines(@backgroundColor, @color) {
.linkUnderlines(@color) {
color: @color;
text-decoration: none;
.textShadowToCropUnderline(@backgroundColor);
background-image: linear-gradient(@backgroundColor, @backgroundColor), linear-gradient(@backgroundColor, @backgroundColor), linear-gradient(@color, @color);
background-size: .05em 1px, .05em 1px, 1px 1px;
background-repeat: no-repeat, no-repeat, repeat-x;
background-position: 0% 90%, 100% 90%, 0% 90%;

&:selection {
.textShadowToCropUnderline(@selectionColor);
background: @selectionColor;
}
&:-moz-selection {
.textShadowToCropUnderline(@selectionColor);
background: @selectionColor;
}
&:before,
&:after,
*,
*:before,
*:after {
text-shadow: none;
}
text-decoration: underline;
-webkit-text-decoration-skip: ink;
text-decoration-skip: ink;

&:visited {
color: @color;
Expand Down
2 changes: 1 addition & 1 deletion assets/less/night/content/general.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ h6 {
a {
color: @nightTextHeaders;
text-decoration: none;
.linkUnderlines(@nightBackground, @nightTextHeaders);
.linkUnderlines(@nightTextHeaders);
}

a.no-underline {
Expand Down
1 change: 0 additions & 1 deletion formatters/html/dist/app-66569d1bfe.css
View file
Open in desktop

This file was deleted.

Loading