Make night mode switch link more obvious

[nscyclone]

This PR introduces another icon just below the menu hamburger to switch between the day and night modes. Closes #558.

Example:

[josevalim]

Thank you! Is it possible to have the icon in the same color as the hamburger icon?

/cc @dignifiedquire

[nscyclone]

Thanks, @josevalim! I'm afraid we can't switch the color of the emoji versions, but we can use the text ones instead. There is an example pen, we could make use of the two glyphs on the left.

Let's wait for a review from @dignifiedquire.

[aphillipo]

I think the icons would be better as:

light -> 🌚 dark -> 🌝

I hate the sun emoji and crescent personally and find them a bit garish and out of place. You might find the same about these of course!

I'd also want to make sure that each of these has a 68x68px clickable area on mobile as it can e difficult to click anything smaller...

[josevalim]

Should we use something from the icon font? Depending on emoji means we have no control over its exhibition.

[OvermindDL1]

Should we use something from the icon font?

If an icon font is available then that should be used, otherwise I'd just use inline svg (could even have some css animate the transition between both forms). Simple CSS needed, no javascript at all needed, and only static svg description in the html (the 'shape' is defined in CSS).

[josevalim]

AFAIK, we already have an icon font.

[nscyclone]

Yes, we have an icon font. It can easily be imported back into icomoon app to append a couple more icons from free packs.

It could look something like this:

The original issue used a Twitter poll to get some feedback. Maybe we should choose a couple of options and make a new poll to let community decide?

[josevalim]

The icon ones look a thousand times better to me so I would go ahead with them unless someone strongly opposes. :)

[dignifiedquire]

agree with @josevalim thank you :)

[nscyclone]

Huge thanks to everyone for all of your input. I've just updated the branch with icons from a recent comment.

The updated version now looks like this:

Looking forward to receive some feedback on this.

[josevalim]

@nscyclone beautiful. One final question: should we remove the link at the bottom of the pages now?

[nscyclone]

@josevalim I've already removed it.

[josevalim]

❤️ 💚 💙 💛 💜