Skip to content

Make night mode switch link more obvious #798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 23, 2017
Merged

Make night mode switch link more obvious #798

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c9a336e
Make night mode switch link more obvious
nscyclone Nov 21, 2017
c443d63
Make night mode switch link more obvious
nscyclone Nov 23, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions assets/less/layout.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,8 @@ body {
}

body.sidebar-opened, body.sidebar-opening {
.sidebar-toggle {
transform: translateX(250px)
.sidebar-button {
transform: translateX(250px);
}

@media screen and (max-width: 768px) {
Expand All @@ -81,17 +81,17 @@ body.sidebar-closed, body.sidebar-closing {
padding-left: 0;
}

.sidebar-toggle {
.sidebar-button {
transform: none;
}
}

body.sidebar-closed .sidebar-toggle {
body.sidebar-closed .sidebar-button {
color: @black;
}

body.sidebar-opening {
.sidebar-toggle {
.sidebar-button {
transition: transform 0.3s ease-in-out;
}

Expand All @@ -117,7 +117,7 @@ body.sidebar-opening {
}

body.sidebar-closing {
.sidebar-toggle {
.sidebar-button {
transition: transform 0.3s ease-in-out;
}

Expand Down
41 changes: 27 additions & 14 deletions assets/less/night/night.less
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,19 @@
.night-mode-toggle {
background: none;
border: none;

&:after {
font-size: 12px;
content: 'Switch to night mode';
text-decoration: underline;
}
top: 1.5em;

&:focus {
outline: none;
}

.icon-theme::before {
@media screen and (max-width: 768px) { font-size: 1em; }

@media screen and (min-width: 769px) { font-size: 1.25em; }

@media screen and (min-width: 1281px) { font-size: 1.5em; }

content: "\e900";
}
}

body.night-mode {
Expand All @@ -21,12 +24,8 @@ body.night-mode {
background: @nightBackground;
}

.night-mode-toggle {
&:after {
color: @mediumGray;
content: 'Switch to day mode';
text-decoration: underline;
}
.night-mode-toggle .icon-theme::before {
content: "\e901";
}

#search .result-id a {
Expand All @@ -42,3 +41,17 @@ body.night-mode {
}

}

@media screen and (max-width: 768px) {
.night-mode-toggle {
transform: translateX(0);
left: 5px;
top: 1.5em;
}

.sidebar-opened {
.night-mode-toggle {
left: 18px;
}
}
}
6 changes: 3 additions & 3 deletions assets/less/night/sidebar.less
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
body.night-mode {
.sidebar-closed .sidebar-toggle, .sidebar-toggle {
color: @lightestGray;
}
.sidebar-closed .sidebar-button, .sidebar-button {
color: @lightestGray;
}
}
12 changes: 7 additions & 5 deletions assets/less/toggle.less
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
.sidebar-toggle {
.sidebar-button {
position: fixed;
z-index: 99;
left: 18px;
top: 8px;
color: @gray;
background-color: transparent;
border: none;
Expand All @@ -21,19 +20,22 @@
&:focus {
outline: none;
}

.sidebar-toggle {
top: 8px;
}
}

@media screen and (max-width: 768px) {
.sidebar-toggle {
.sidebar-button {
transform: translateX(0);
left: 5px;
top: 5px;
}

.sidebar-opened {
.sidebar-toggle {
.sidebar-button {
left: 18px;
top: 5px;
}
}
}
1 change: 0 additions & 1 deletion formatters/html/dist/app-c11171effc.css
View file
Open in desktop

This file was deleted.

1 change: 1 addition & 0 deletions formatters/html/dist/app-de6b7c05d7.css
View file
Open in desktop

Large diffs are not rendered by default.

Binary file modified formatters/html/fonts/icomoon.eot
View file
Open in desktop
Binary file not shown.
14 changes: 8 additions & 6 deletions formatters/html/fonts/icomoon.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified formatters/html/fonts/icomoon.ttf
View file
Open in desktop
Binary file not shown.
Binary file modified formatters/html/fonts/icomoon.woff
View file
Open in desktop
Binary file not shown.
1 change: 0 additions & 1 deletion lib/ex_doc/formatter/html/templates/footer_template.eex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
<a href="https://twitter.com/dignifiedquire" target="_blank" title="@dignifiedquire">Friedel Ziegelmayer</a>.
</span>
</p>
<button class="night-mode-toggle"><span class="sr-only">Switch theme</span></button>
</footer>
</div>
</div>
Expand Down
6 changes: 5 additions & 1 deletion lib/ex_doc/formatter/html/templates/sidebar_template.eex
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,12 @@
<div class="main">
<button class="sidebar-toggle">
<button class="sidebar-button sidebar-toggle">
<span class="icon-menu" aria-hidden="true"></span>
<span class="sr-only">Toggle Sidebar</span>
</button>
<button class="sidebar-button night-mode-toggle">
<span class="icon-theme" aria-hidden="true"></span>
<span class="sr-only">Toggle Theme</span>
</button>
<section class="sidebar">

<% url = config.homepage_url || "#{config.main}.html" %>
Expand Down