Exclude types with @typedoc false from generated documentation
#858
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why there are there changes to the front-end code as well? Other than that, this looks good to me. |
|
As @michalmuskala said, it looks great, you should just remove the front end changes. :) |
arkgil
force-pushed
the
exclude-typedoc-false
branch
from
5c0267a to
27c0de9
Compare
|
Yeah, I wasn't sure about it. I've just read the contributing guide and committed them. Anyway, I've removed these changes 🙂 |
michalmuskala
approved these changes
Jun 14, 2018
|
❤️ 💚 💙 💛 💜 |
|
Thanks for the spot, @arkgil! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the bug when ExDoc included documentation for types with
@typedoc false.Closes #857