ci: conventional commits #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we are going to use release-please to manage our releases and changelog, we need to start using conventional commits and the Squash and Merge style of PR merging. This workflow will lint the pull request title to ensure that it follows conventional commits, since the title will be used as the commit subject when squash and merging
Member
Author
|
Since this uses pull_request_target, I believe it won't actually run until its is merged and lives on main. |
doorgan
approved these changes
Jul 3, 2025
Collaborator
doorgan
left a comment
doorgan
left a comment
There was a problem hiding this comment.
Comparing with the next-ls ci, this looks like it should work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we are going to use release-please to manage our releases and
changelog, we need to start using conventional commits and the Squash
and Merge style of PR merging.
This workflow will lint the pull request title to ensure that it follows
conventional commits, since the title will be used as the commit subject
when squash and merging