Skip to content

Conversation

@doorgan
Copy link
Collaborator

@doorgan doorgan commented Jul 4, 2025

After we transitioned to GenLSP, I was no longer able to make Expert work with the Lexical vscode extension, so I would only be able to test it with neovim.

Apparently this is caused by two issues:

  • Because we weren't doing the dynamic registrations when receiving the Initialized notification but rather in the initialization request, vscode stopped sending requests to the server
  • I don't fully understand why, but if we start the project node synchronously on initialization, genlsp will apparently stop handling requests/notifictations from the vscode client, causing the client to cancel every request.

Fixing those two things I got Expert fully working on vscode again. I accidentally found those fixes while working on workpsace folders support, where the project nodes are started when files are opened instead of on initialization.

@doorgan doorgan merged commit e1ce165 into main Jul 7, 2025
0 of 15 checks passed
@doorgan doorgan deleted the doorgan/fix_vscode branch July 7, 2025 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants