-
-
Notifications
You must be signed in to change notification settings - Fork 43
chore: update release workflow #37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| @@ -0,0 +1 @@ | |||
| 0.1.0 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call on this.
I think there might have to be something done to the release please config in order for it to bump this file.
Also, we probably don't need to set the release-type to elixir anymore, maybe we just need to set it to "simple", but I think that also might bump a "version.txt" file.
I use that method in elixir-tools.nvim here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I think we can definitely follow that route and use the version.txt instead, it's the same idea
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mhanberg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fire fire flame flame 🔥


We're running out of CI minutes in this org so I tested this workflow on a private org with no actions limits
This is largely based on NextLS release workflow: https://github.com/elixir-tools/next-ls/blob/main/.github/workflows/release.yaml