-
-
Notifications
You must be signed in to change notification settings - Fork 43
fix: refactor flake.nix to build burrito app and allow elixir/erlang version overriding #96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…w-nix-override * 'main' of github.com:elixir-lang/expert: docs: update VSCode instructions chore: add .tool-versions for zig (elixir-lang#88) fix: make sure asdf shims are in the PATH (elixir-lang#87) docs: add zig installation instructions to installation prerequisites (elixir-lang#85) fix: trim any quotes wrapping PATH when elixir is managed by mise (elixir-lang#82) ci: tweak text in commit title comment ci: post comment on PR when it fails the semantic pr title docs: add zed to installation (elixir-lang#71) docs: update nightly installation instructions (elixir-lang#67) docs: fix zig version in README.md (elixir-lang#66) chore: add install task to justfile (elixir-lang#65)
|
Hey, just wanted to say thank you for the fix!! |
|
this new working derivation also introduces new 'dependencies' which will not reuse nixpkgs prebuilt cache burrito only have prebuilt so, although this derivation works well, i would only proceed with this pr changes once burrito handles the latest release of also, the derivation correctly only compile the desired |
|
i've also took the opportunity to simplify |
|
For nixpkgs, we don't really need to use burrito at all. Nix on Darwin systems also doesn't enable the network sandbox, but on NixOS it would actually fail because it would block burrito from downloading OTP anyway. In Next LS, we opted for a standard mix release since nix is taking care of the dependencies. Thank you for this patch tho, I'll take a look. I was working on this a couple nights ago but the monorepo aspect was making it difficult. Question: does the beam workspace still work without flake-parts? nix-beam-flakes is a flake-parts module. |
yeah, that's a nice question. i got excited to refactor and probably missed that. for now i will only come back with the for burrito... well, we can just make a wrapper script indeed, but it was easier first just to rely on burrito, the main tricky part was indeed the multi-app setup - without umbrella. will try a version without burrito, like next-ls (i think lexical too) does |
|
I pulled this down on NixOS, the beam workspace does not work, and it doesn't build. In Next LS, we didn't use burrito because there really isn't any point. It can't download its own OTP builds because of the build sandbox (which isn't used on darwin, only Linux) and Nix already packages the software and distributes it, which defeats the point of Burrito. Thank you so much for the effort, but I'm going to close this in favor of #106 |
firstly, thanks for all the hard work! 💜
the original
flake.nixwas derived directly from lexical since its the base source code, howeverexpertuses a multi-app (not umbrella) setup and uses burrito for distribution.those new requirements creates new complexities for the nix derivation building, so i need to make some tweaks, specially for burrito outputs artifacts.
i successflly builded on macos m1, whish if this PR makes sense for the project on medium-term time.
Closes #95