-
Notifications
You must be signed in to change notification settings - Fork 116
Introduce new HTTP/1 option for status reason-phrase #471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 589a11aadabf3b16e7cad7c8295cb8381570e43d-PR-471Details
💛 - Coveralls |
wojtekmach
reviewed
Oct 20, 2025
whatyouhide
approved these changes
Oct 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic! 🫶
Comment on lines
+134
to
+139
| * `:optional_responses` - (list of atoms) a list of optional responses to return. | ||
| The possible values in the list are - | ||
| * `:status_reason` which will return the | ||
| [reason-phrase](https://datatracker.ietf.org/doc/html/rfc9112#name-status-line) | ||
| for the status code, if it is returned by the server in status-line. | ||
| This is only available for HTTP/1.1 connections. *Available since v1.7.2*. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
| * `:optional_responses` - (list of atoms) a list of optional responses to return. | |
| The possible values in the list are - | |
| * `:status_reason` which will return the | |
| [reason-phrase](https://datatracker.ietf.org/doc/html/rfc9112#name-status-line) | |
| for the status code, if it is returned by the server in status-line. | |
| This is only available for HTTP/1.1 connections. *Available since v1.7.2*. | |
| * `:optional_responses` - (list of atoms) a list of optional responses to return. | |
| Defaults to `[]`. The possible values in the list are: | |
| * `:status_reason`: will include the | |
| [reason-phrase](https://datatracker.ietf.org/doc/html/rfc9112#name-status-line) | |
| for the status code (if it is returned by the server in status-line) in the response. | |
| This is only available for HTTP/1.1 connections. *Available since v1.7.2*. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #465
Currently, we are ignoring the
reason-phrasefromstatus-line.For backward compatibility, this is an optional parameter.
This PR adds an option at the connection time, that will return the
reason-phrasein the response.