Skip to content

Conversation

@nickgnd
Copy link
Contributor

@nickgnd nickgnd commented Feb 5, 2023

Hey 👋
I'm opening this small PR to fix a discrepancy in the docs for the option channels used in the Conv layers and others.

The default value for the :channels option is :last based on what I can see in the code (e.g. here).

Note that in the Axon module docs, the default value for the option is correct, only in the Axon.Layers it was outdated/incorrect (:first).

Cheers ✌️

The defualt value for the `:channels` option is `:last`. Note that
in the `Axon` module docs the default value was correct, only in the
`Axon.Layers` it was outdated/incorrect (`:first`).
Copy link
Contributor

@seanmor5 seanmor5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@seanmor5 seanmor5 merged commit cd37a8a into elixir-nx:main Feb 6, 2023
@nickgnd nickgnd deleted the docs/update-layers-documentation-for-channels-option branch February 6, 2023 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants