Skip to content

Conversation

@seanmor5
Copy link
Contributor

No description provided.

@josevalim josevalim requested a review from philss October 10, 2022 13:37
@jonatanklosko
Copy link
Member

I get this locally:

$ cross build --release --target aarch64-unknown-linux-musl --features static_openssl

[...]

error: cannot produce cdylib for `ex_tokenizers v0.1.0 (/home/jonatanklosko/dev/tokenizers/native/ex_tokenizers)` as the target `aarch64-unknown-linux-musl` does not support these crate types

@seanmor5
Copy link
Contributor Author

Oh yeah, I had to set:

RUSTFLAGS="-C target-feature=-crt-static"

@seanmor5
Copy link
Contributor Author

I assumed though that was because I was trying to build on Mac, but maybe not :)

@jonatanklosko
Copy link
Member

@seanmor5 this fixes it for me, we likely need that on CI too :)

Copy link
Member

@jonatanklosko jonatanklosko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but let's wait for @philss :D

Copy link

@philss philss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small point :)

Copy link

@philss philss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@seanmor5 seanmor5 merged commit 115984d into main Oct 11, 2022
@seanmor5 seanmor5 deleted the sm-musl branch October 11, 2022 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants