Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTPS guide #803

Merged
merged 8 commits into from Jan 7, 2019

Conversation

Projects
None yet
3 participants
@voltone
Copy link
Contributor

commented Dec 19, 2018

See discussion in #749

@Gazler

Gazler approved these changes Dec 21, 2018

Copy link
Member

left a comment

Amazing work. So many of the common edge cases encountered have been covered here, so should definitely help people out!

Show resolved Hide resolved guides/https.md Outdated
Show resolved Hide resolved guides/https.md Outdated
Show resolved Hide resolved guides/https.md Outdated
Show resolved Hide resolved guides/https.md

@voltone voltone force-pushed the voltone:https_guide branch from 99f05df to 3c8f7c9 Dec 31, 2018

@josevalim

This comment has been minimized.

Copy link
Member

commented Jan 5, 2019

This is excellent @voltone, thank you! Unless there are any other concerns, we will ship this. :)

/cc @idyll @Gazler

@voltone

This comment has been minimized.

Copy link
Contributor Author

commented Jan 7, 2019

Just pushed a few last minute fixes. I guess I'll never be 100% happy with anything I write, but at some point I just have to let it go...

@josevalim

This comment has been minimized.

Copy link
Member

commented Jan 7, 2019

@voltone :D You don't have to worry because once it is out, other people read and review it and provide more fixes. But I usually do two or three passes on the docs I write. :)

@josevalim josevalim merged commit 461f581 into elixir-plug:master Jan 7, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@josevalim

This comment has been minimized.

Copy link
Member

commented Jan 7, 2019

❤️ 💚 💙 💛 💜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.