Skip to content

Conversation

voltone
Copy link
Contributor

@voltone voltone commented Dec 19, 2018

See discussion in #749

Copy link
Member

@Gazler Gazler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work. So many of the common edge cases encountered have been covered here, so should definitely help people out!

@josevalim
Copy link
Member

This is excellent @voltone, thank you! Unless there are any other concerns, we will ship this. :)

/cc @idyll @Gazler

@voltone
Copy link
Contributor Author

voltone commented Jan 7, 2019

Just pushed a few last minute fixes. I guess I'll never be 100% happy with anything I write, but at some point I just have to let it go...

@josevalim
Copy link
Member

@voltone :D You don't have to worry because once it is out, other people read and review it and provide more fixes. But I usually do two or three passes on the docs I write. :)

@josevalim josevalim merged commit 461f581 into elixir-plug:master Jan 7, 2019
@josevalim
Copy link
Member

❤️ 💚 💙 💛 💜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants