Skip to content

Optimize decoding of keys and packed fields #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 20, 2020
Merged

Optimize decoding of keys and packed fields #121

merged 4 commits into from
Jul 20, 2020

Conversation

@britto
Copy link
Collaborator

@britto britto commented Jul 7, 2020 •
edited
Loading

Benchmark results:

##### With input google_message1_proto2 #####
Name                                              ips        average  deviation         median         99th %
decode (optimize-packed-99926e5-decode)       61.33 K       16.31 μs   ±963.31%           8 μs          30 μs
decode (master-3428d3a-decode)                51.89 K       19.27 μs   ±883.01%           9 μs          37 μs

Comparison: 
decode (optimize-packed-99926e5-decode)       61.33 K
decode (master-3428d3a-decode)                51.89 K - 6.59x slower +16.35 μs

Memory usage statistics:

Name                                       Memory usage
decode (optimize-packed-99926e5-decode)         6.84 KB
decode (master-3428d3a-decode)                  8.48 KB - 9.44x memory usage +7.59 KB

##### With input google_message1_proto3 #####
Name                                              ips        average  deviation         median         99th %
decode (optimize-packed-99926e5-decode)       63.38 K       15.78 μs  ±1019.98%           8 μs          21 μs
decode (master-3428d3a-decode)                54.42 K       18.38 μs   ±939.82%           9 μs          20 μs

Comparison: 
decode (optimize-packed-99926e5-decode)       63.38 K
decode (master-3428d3a-decode)                54.42 K - 6.29x slower +15.45 μs

Memory usage statistics:

Name                                       Memory usage
decode (optimize-packed-99926e5-decode)         6.84 KB
decode (master-3428d3a-decode)                  8.48 KB - 9.44x memory usage +7.59 KB

##### With input google_message2 #####
Name                                              ips        average  deviation         median         99th %
decode (optimize-packed-99926e5-decode)        864.75        1.16 ms     ±4.05%        1.16 ms        1.28 ms
decode (master-3428d3a-decode)                 687.49        1.45 ms     ±6.05%        1.45 ms        1.68 ms

Comparison: 
decode (optimize-packed-99926e5-decode)        864.75
decode (master-3428d3a-decode)                 687.49 - 497.55x slower +1.45 ms

Memory usage statistics:

Name                                       Memory usage
decode (optimize-packed-99926e5-decode)        23.74 KB
decode (master-3428d3a-decode)                731.05 KB - 813.69x memory usage +730.15 KB

##### With input google_message3_1 #####
Name                                              ips        average  deviation         median         99th %
decode (optimize-packed-99926e5-decode)         0.135         7.42 s     ±1.45%         7.36 s         7.55 s
decode (master-3428d3a-decode)                  0.118         8.50 s     ±0.44%         8.52 s         8.53 s

Comparison: 
decode (optimize-packed-99926e5-decode)         0.135
decode (master-3428d3a-decode)                  0.118 - 2908349.55x slower +8.50 s

Memory usage statistics:

Name                                       Memory usage
decode (optimize-packed-99926e5-decode)         1.67 GB
decode (master-3428d3a-decode)                  2.05 GB - 2389926.57x memory usage +2.05 GB

##### With input google_message3_2 #####
Name                                              ips        average  deviation         median         99th %
decode (optimize-packed-99926e5-decode)         90.47       11.05 ms     ±3.35%       11.01 ms       12.05 ms
decode (master-3428d3a-decode)                  75.38       13.27 ms     ±2.65%       13.23 ms       14.03 ms

Comparison: 
decode (optimize-packed-99926e5-decode)         90.47
decode (master-3428d3a-decode)                  75.38 - 4537.74x slower +13.26 ms

Memory usage statistics:

Name                                       Memory usage
decode (optimize-packed-99926e5-decode)         2.89 MB
decode (master-3428d3a-decode)                  7.26 MB - 8275.49x memory usage +7.26 MB

##### With input google_message3_3 #####
Name                                              ips        average  deviation         median         99th %
decode (optimize-packed-99926e5-decode)      177.29 K        5.64 μs  ±2641.69%           3 μs           7 μs
decode (master-3428d3a-decode)               151.92 K        6.58 μs  ±2447.36%           3 μs           6 μs

Comparison: 
decode (optimize-packed-99926e5-decode)      177.29 K
decode (master-3428d3a-decode)               151.92 K - 2.25x slower +3.66 μs

Memory usage statistics:

Name                                       Memory usage
decode (optimize-packed-99926e5-decode)         1.88 KB
decode (master-3428d3a-decode)                  2.52 KB - 2.81x memory usage +1.63 KB

##### With input google_message3_4 #####
Name                                              ips        average  deviation         median         99th %
decode (optimize-packed-99926e5-decode)      336.87 K        2.97 μs  ±4976.75%           1 μs           4 μs
decode (master-3428d3a-decode)               286.98 K        3.48 μs  ±4476.92%           2 μs           4 μs

Comparison: 
decode (optimize-packed-99926e5-decode)      336.87 K
decode (master-3428d3a-decode)               286.98 K - 1.19x slower +0.56 μs

Memory usage statistics:

Name                                       Memory usage
decode (optimize-packed-99926e5-decode)         0.90 KB
decode (master-3428d3a-decode)                  1.25 KB - 1.39x memory usage +0.35 KB

##### With input google_message3_5 #####
Name                                              ips        average  deviation         median         99th %
decode (optimize-packed-99926e5-decode)      342.06 K        2.92 μs  ±5211.57%           1 μs           4 μs
decode (master-3428d3a-decode)               287.16 K        3.48 μs  ±4507.40%           2 μs           4 μs

Comparison: 
decode (optimize-packed-99926e5-decode)      342.06 K
decode (master-3428d3a-decode)               287.16 K - 1.19x slower +0.56 μs

Memory usage statistics:

Name                                       Memory usage
decode (optimize-packed-99926e5-decode)         0.90 KB
decode (master-3428d3a-decode)                  1.25 KB - 1.39x memory usage +0.35 KB

##### With input google_message4 #####
Name                                              ips        average  deviation         median         99th %
decode (optimize-packed-99926e5-decode)      143.56 K        6.97 μs  ±2087.90%           4 μs           6 μs
decode (master-3428d3a-decode)               121.78 K        8.21 μs  ±1876.36%           4 μs           9 μs

Comparison: 
decode (optimize-packed-99926e5-decode)      143.56 K
decode (master-3428d3a-decode)               121.78 K - 2.81x slower +5.29 μs

Memory usage statistics:

Name                                       Memory usage
decode (optimize-packed-99926e5-decode)         2.31 KB
decode (master-3428d3a-decode)                  3.02 KB - 3.37x memory usage +2.13 KB

britto added 3 commits July 6, 2020 22:32
@britto
Optimize binary matching in raw_handle_key to support context reuse
4a96782
@britto
Optimize packed fields decoding
2d70fe6 
No need to interpret group data here because packed fields are decoded
afterwards, during build_struct, when groups have already been skipped.
@britto
Optimize packed fields decoding
c0a1559 
By matching wire type once, since all values have the same type.
@britto britto force-pushed the optimize-packed branch from 99926e5 to 3273713 Compare July 9, 2020 04:47
@britto
Optimize decoding of sparse packed fields
b11d326 
When same the packed field is found multiple times over the wire, prepend
to its accumulator instead of triggering ++.
@britto britto force-pushed the optimize-packed branch from 3273713 to b11d326 Compare July 9, 2020 04:53
@britto britto mentioned this pull request Jul 11, 2020
Merged
@whatyouhide whatyouhide merged commit 3e493cc into elixir-protobuf:master Jul 20, 2020
@britto britto deleted the optimize-packed branch May 31, 2021 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@britto @whatyouhide