Skip to content

Check for compilation and formatting issues on CI #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 11, 2021
Merged

Check for compilation and formatting issues on CI #161

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c77a209
Check for compilation and formatting issues on CI.
britto Jun 9, 2021
c4c95e0
Tweak build matrix
britto Jun 9, 2021
3607226
Apply code formatter.
britto Jun 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,22 +5,20 @@ on: [push, pull_request]
jobs:
test:
name: Test (Elixir ${{matrix.elixir}} | Erlang/OTP ${{matrix.otp}})
runs-on: ubuntu-16.04
runs-on: ubuntu-18.04
strategy:
fail-fast: false
matrix:
include:
- otp: 24.0
elixir: 1.12.1
lint: true
integration: true
- otp: 23.3
elixir: 1.11.4
lint: true
integration: true
- otp: 23.3
elixir: 1.10.4
- otp: 22.3
elixir: 1.10.4
- otp: 22.3
elixir: 1.9.4
env:
Expand All @@ -37,12 +35,17 @@ jobs:
- name: Install dependencies
run: mix deps.get --only test

- name: Check no unused dependencies
- name: Check for unused dependencies
run: mix deps.get && mix deps.unlock --check-unused
if: ${{matrix.lint}}

- name: Compile dependencies
run: mix deps.compile
- name: Compile with --warnings-as-errors
run: mix compile --warnings-as-errors
if: ${{matrix.lint}}

- name: Check mix format
run: mix format --check-formatted
if: ${{matrix.lint}}

- name: Run tests
run: mix test --trace
Expand Down
1 change: 0 additions & 1 deletion lib/protobuf/protoc/generator/message.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,6 @@ defmodule Protobuf.Protoc.Generator.Message do
{fmt_type_name(f.name, longest_width), "{atom, any}"}
end)


types =
types ++
Enum.map(fields, fn f ->
Expand Down