fragments in select

[ruslandoga]

This query doesn't seem to work with SQLite3

ecto_sqlite3/test/ecto/adapters/sqlite3/connection_test.exs

Lines 139 to 144 in 6dcc0b2

	query =
	"posts"
	|> select([r], fragment("?", r))
	|> plan()
	assert all(query) == ~s{SELECT p0 FROM "posts" AS p0}

sqlite> create table example(a integer);

sqlite> select e0 from "example" as e0;
Parse error: no such column: e0
  select e0 from "example" as e0;
         ^--- error here

I wonder if there is something we can do about it. Either raise or add .*.

[ruslandoga]

Postgrex has a similar test case

https://github.com/elixir-ecto/ecto_sql/blob/c7d58a3f963cc605ef73c4eec2c03fc46c6db804/test/ecto/adapters/postgres_test.exs#L87-L88

But it seems to work in PostgreSQL: I've tried select u0 from users u0.

[warmwaffles]

Oh that's confusing. We should do what is right and just raise here honestly. Doing a naked select like that and appending .* seems risky to me. Calls to the DB should be explicit and not so ambiguous. Thoughts?