Skip to content

Fix update_all with select raises error #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix update_all with select raises error #31

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions test/ecto/integration/crud_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,29 @@ defmodule Ecto.Integration.CrudTest do
assert changed.name == "Bob"
end

test "update_all with select returns a row count of 0 when no records were updated" do
{:ok, _lj} = TestRepo.insert(%User{name: "Lebron James"}, [])

no_match_query =
from(
a in Account,
where: a.name == "Michael Jordan",
select: %{name: a.name}
)

assert {0, nil} = TestRepo.update_all(no_match_query, set: [name: "G.O.A.T"])

match_query =
from(
a in Account,
where: a.name == "Lebron James",
select: %{name: a.name}
)

assert {1, %{name: "Lebron James"}} =
TestRepo.update_all(match_query, set: [name: "G.O.A.T"])
end

test "update_all handles null<->nil conversion correctly" do
account = TestRepo.insert!(%Account{name: "hello"})
assert {1, nil} = TestRepo.update_all(Account, set: [name: nil])
Expand Down