Skip to content

feat: add version configuration to CredoLS and NextLS #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 12, 2023
Merged

feat: add version configuration to CredoLS and NextLS #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6f8a2e8
feat: Add version configuration to CredoLS and NextLS
sineed Jul 8, 2023
d50ceda
Apply suggestions from code review
mhanberg Jul 12, 2023
a774997
fixup! Apply suggestions from code review
mhanberg Jul 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 16 additions & 6 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
"elixir-tools.credo.enable": {
"type": "boolean",
"default": true,
"description": "Whether to start the Credo Language Server."
"markdownDescription": "Whether to start **Credo Language Server**"
},
"elixir-tools.credo.adapter": {
"type": "string",
Expand All @@ -44,17 +44,22 @@
"tcp"
],
"default": "stdio",
"description": "Which adapter to use when connecting to credo-language-server"
"markdownDescription": "Which adapter to use when connecting to **Credo Language Server**."
},
"elixir-tools.credo.port": {
"type": "integer",
"default": 9000,
"description": "If adapter is `tcp`, use this port to connect."
"markdownDescription": "If adapter is `tcp`, use this port to connect."
},
"elixir-tools.credo.version": {
"type": "string",
"default": "latest",
"markdownDescription": "Specifies the version of **Credo Language Server**.\n\nDefaults to `latest`."
},
"elixir-tools.nextls.enable": {
"type": "boolean",
"default": false,
"description": "Whether to start NextLS."
"markdownDescription": "Whether to start **Next LS**."
},
"elixir-tools.nextls.adapter": {
"type": "string",
Expand All @@ -63,12 +68,17 @@
"tcp"
],
"default": "stdio",
"description": "Which adapter to use when connecting to NextLS"
"markdownDescription": "Which adapter to use when connecting to **Next LS**."
},
"elixir-tools.nextls.port": {
"type": "integer",
"default": 9000,
"description": "If adapter is `tcp`, use this port to connect."
"markdownDescription": "If adapter is `tcp`, use this port to connect."
},
"elixir-tools.nextls.version": {
"type": "string",
"default": "latest",
"markdownDescription": "Specifies the version of **Next LS**.\n\nDefaults to `latest`."
}
}
},
Expand Down
18 changes: 14 additions & 4 deletions src/extension.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,12 +39,16 @@ async function activateCredo(

switch (config.get("adapter")) {
case "stdio":
let version = config.get("version");

if (version === "latest") {
version = await latestRelease("credo-language-server");
}

serverOptions = {
options: {
env: Object.assign({}, process.env, {
["CREDO_LSP_VERSION"]: await latestRelease(
"credo-language-server"
),
["CREDO_LSP_VERSION"]: version,
}),
},
command: context.asAbsolutePath("./bin/credo-language-server"),
Expand Down Expand Up @@ -96,10 +100,16 @@ async function activateNextLS(

switch (config.get("adapter")) {
case "stdio":
let version = config.get("version");

if (version === "latest") {
version = await latestRelease("next-ls");
}

serverOptions = {
options: {
env: Object.assign({}, process.env, {
["NEXTLS_VERSION"]: await latestRelease("next-ls"),
["NEXTLS_VERSION"]: version,
}),
},
command: context.asAbsolutePath("./bin/nextls"),
Expand Down