When logging a screenshot, use Logger.info instead of IO.puts #667
msimonborg
started this conversation in
General
Replies: 1 comment
-
|
It already used IO.puts when I came onto to the project, so I couldn't really tell you why. We would not use Logger.info tho, because most projects have their test env configured to only show warning and error logs, so it would be confusing to attempt to log it and not see it. I am not familiar with RingLogger, is there a reason why you don't want anything printed to stdout when you run your tests? |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
I use RingLogger to keep my logs out of stdout unless I explicitly call for them. When I passed
log: trueas an option toWallaby.Browser.take_screenshot/2I assumed that it would respect my logging configuration rather than ignore it. Is there a reason why this option usesIO.putsinstead ofLogger.info?Beta Was this translation helpful? Give feedback.
All reactions