Skip to content

Fix CPPCheck Issues - Member function can be const #29

@eljonny

Description

@eljonny

These CPPCheck issues need to be investigated - and possibly corrected (they are in the inconclusive sub-category)

include/internal/TestCPPTestCase.h:292:14: style: inconclusive: Technically the member function 'TestCPP::TestCase::logFailure' can be const. [functionConst]
        void logFailure (ostream& out, string& reason);
             ^
src/TestCPPTestCase.cpp:292:20: note: Technically the member function 'TestCPP::TestCase::logFailure' can be const.
    void TestCase::logFailure(ostream& out, string& reason) {
                   ^
include/internal/TestCPPTestCase.h:292:14: note: Technically the member function 'TestCPP::TestCase::logFailure' can be const.
        void logFailure (ostream& out, string& reason);
             ^
include/internal/TestCPPTestSuite.h:153:18: style: inconclusive: Technically the member function 'TestCPP::TestSuite::getLastRunFailCount' can be const. [functionConst]
        unsigned getLastRunFailCount ();
                 ^
src/TestCPPTestSuite.cpp:73:25: note: Technically the member function 'TestCPP::TestSuite::getLastRunFailCount' can be const.
    unsigned TestSuite::getLastRunFailCount () {
                        ^
include/internal/TestCPPTestSuite.h:153:18: note: Technically the member function 'TestCPP::TestSuite::getLastRunFailCount' can be const.
        unsigned getLastRunFailCount ();
                 ^
include/internal/TestCPPTestSuite.h:156:18: style: inconclusive: Technically the member function 'TestCPP::TestSuite::getLastRunSuccessCount' can be const. [functionConst]
        unsigned getLastRunSuccessCount();
                 ^
src/TestCPPTestSuite.cpp:77:25: note: Technically the member function 'TestCPP::TestSuite::getLastRunSuccessCount' can be const.
    unsigned TestSuite::getLastRunSuccessCount() {
                        ^
include/internal/TestCPPTestSuite.h:156:18: note: Technically the member function 'TestCPP::TestSuite::getLastRunSuccessCount' can be const.
        unsigned getLastRunSuccessCount();
                 ^
include/internal/TestCPPUtil.h:81:23: style: inconclusive: Technically the member function 'TestCPP::TestObjName::getName' can be const. [functionConst]
        const string& getName ();
                      ^
src/TestCPPUtil.cpp:59:32: note: Technically the member function 'TestCPP::TestObjName::getName' can be const.
    const string& TestObjName::getName () {
                               ^
include/internal/TestCPPUtil.h:81:23: note: Technically the member function 'TestCPP::TestObjName::getName' can be const.
        const string& getName ();
                      ^

Metadata

Metadata

Assignees

Labels

static-analysisAn issue related to a static analysis resulttest-caseRelating to TestCPP TestCasetest-suiteRelating to TestCPP TestSuitetest-utilsRelated to TestCPP util functions and TestCPPUtil

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions