Skip to content

Conversation

@jvoigtlaender
Copy link
Contributor

Part of fixing #450.

evancz pushed a commit that referenced this pull request Jan 1, 2016
Fix link to Json Value type in interop guide
@evancz evancz merged commit c179b1d into elm:master Jan 1, 2016
@evancz
Copy link
Member

evancz commented Jan 1, 2016

I think it'd be good to make it clear somehow that Json.Decode.Value can go through too. I couldn't figure out a module structure that made this pleasant. Maybe we can do it in words though. Like:

JavaScript values like Json.Encode.Value and Json.Decode.Value, allowing arbitrary things through in a safe way.

@jvoigtlaender jvoigtlaender deleted the patch-1 branch January 1, 2016 20:37
@jvoigtlaender
Copy link
Contributor Author

Yeah, pointing out both Json.Encode.Value and Json.Decode.Value would be good. It would also be good, though, to make clear that both are actually the same type. Currently, the documentation at http://package.elm-lang.org/packages/elm-lang/core/3.0.0/Json-Decode#Value reads thus:

type alias Value = Value

It would be so much better if it instead were to read thus:

type alias Value = Json.Encode.Value

That is, to have this feature back.

@evancz
Copy link
Member

evancz commented Jan 1, 2016

Sure, I saw your comment about that, but it's not blocking anything in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants