Skip to content

Conversation

@jcs090218
Copy link
Member

For #141.

@jcs090218 jcs090218 added the enhancement New feature or request label Mar 6, 2023
@Fuco1
Copy link
Contributor

Fuco1 commented Mar 6, 2023

I tried this here and it seems to work fine. https://github.com/Fuco1/org-pretty-table/actions/runs/4342695733

One thing I don't get is that it does not add "install-deps" step. Is this automatically handled by the setup-eask action? If not, I would add it to the workflow file.

@jcs090218
Copy link
Member Author

jcs090218 commented Mar 6, 2023

It is handled by eask install. By default, when you install a package, package.el will install all required dependencies.

But yes, if you are using test frameworks or development packages. You will need eask install-deps --dev!

@jcs090218 jcs090218 merged commit 0c45eb2 into master Mar 6, 2023
@jcs090218 jcs090218 deleted the feature/github-wrokflow branch March 6, 2023 21:27
@jcs090218
Copy link
Member Author

jcs090218 commented Mar 6, 2023

Oh, BTW, the single file template is located in https://github.com/emacs-eask/template-generate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants