Skip to content

verbose option should check for NaN #365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 13, 2025
Merged

verbose option should check for NaN #365

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7a1d8da
Fix: vebose option should error if no number is given
joshbax189 Nov 12, 2025
84b2d75
Add tests for verbose option
joshbax189 Nov 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/util.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,6 +212,14 @@ async function e_call(argv, script, ...args) {
return;
}

if (argv.verbose !== undefined &&
// this must exclude NaN -- yargs default value for numeric type
!(argv.verbose >= 0 && argv.verbose <= 5)) {
console.warn("invalid value for --verbose option: must be a number between 0 and 5");
process.exit(1);
return;
}

return new Promise(resolve => {
let _path = el_script(script);

Expand Down
12 changes: 12 additions & 0 deletions test/jest/options.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,18 @@ describe("options", () => {
});
});

describe("verbose option", () => {
it("should error if no number is given", async () => {
await expect(ctx.runEask("info -v")).rejects.toMatchObject({ code: 1 });
});

it("should error if the number is omitted before the next option", async () => {
await expect(ctx.runEask("info -v --no-color")).rejects.toMatchObject({
code: 1,
});
});
});

test.each([
"-a",
"--all",
Expand Down
Loading