fix: copilot respects the value of lsp-copilot-enabled [fixes #4679] #4683
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kassick
changed the title
kassick
changed the title
Contributor
Author
|
Fixes #4679 |
kiennq
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lsp-modesugests installing copilot-ls for any supported major-mode that has a installable server. This results in users installing the copilot server when they did not intend to use copilot.Once installed, copilot-ls would try to log in every time the client started.
This PR updates the copilot client to, by default, activate only when
lsp-copilot-enabledis non-nil.It also adds a hint to the user in the login function, helping them find how to disable copilot.