Skip to content

Configure typescript-language-server to be default #598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 19, 2019
Merged

Configure typescript-language-server to be default #598

merged 1 commit into from
Jan 19, 2019

Conversation

@yyoncho
Copy link
Member

@yyoncho yyoncho commented Jan 18, 2019

No description provided.

@yyoncho
Copy link
Member Author

yyoncho commented Jan 18, 2019

@seagle0128

@yyoncho yyoncho merged commit 4f12de8 into emacs-lsp:master Jan 19, 2019
@seagle0128
Copy link
Collaborator

seagle0128 commented Jan 19, 2019

Sorry for the late response due to the weekend!
Thanks for your work! I did reviews and testing in my env. One problem, lsp-clients-typescript-server-args should be set to --stdio by default IMO.

@yyoncho
Copy link
Member Author

yyoncho commented Jan 19, 2019

@seagle0128 thanks for the testing. I will redo my verification locally and update it accordingly.

@yyoncho
Copy link
Member Author

yyoncho commented Jan 19, 2019

Fixed with df8bbdb .

@seagle0128
Copy link
Collaborator

seagle0128 commented Jan 19, 2019

Thank you.
BTW, I'm glad to see doom-modeline in the screenshot 😄

dochang added a commit to dochang/dotfiles that referenced this pull request Mar 22, 2019
@dochang
Use typescript-language-server instead of javascript-typescript-langs…
67d6607 
…erver

emacs-lsp/lsp-mode@3154b6c

emacs-lsp/lsp-mode#509

emacs-lsp/lsp-mode@4f12de8

emacs-lsp/lsp-mode#598
dochang added a commit to dochang/dotfiles that referenced this pull request Apr 10, 2019
@dochang
Use typescript-language-server instead of javascript-typescript-langs…
f960ea7 
…erver

emacs-lsp/lsp-mode@3154b6c

emacs-lsp/lsp-mode#509

emacs-lsp/lsp-mode@4f12de8

emacs-lsp/lsp-mode#598
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yyoncho @seagle0128