Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Sep 4, 2018

Added "deleteMailbox" implementation. see #157

@felixhammerl
Copy link
Contributor

Thanks for the submission! Before I merge this, could you...

  • fix the linter errors,
  • add a test,
  • remove the async/await as it doesn't really make a lot of sense to await the result of the computation if we're going to re-throw the error anyway. Just return whatever Promise comes back from exec.

Cheers
Felix

@ghost
Copy link
Author

ghost commented Sep 5, 2018

i've pushed another commit, please tell me if another update is required :)

@felixhammerl felixhammerl merged commit 32e768c into emailjs:master Sep 6, 2018
@smallbitt
Copy link

smallbitt commented Feb 3, 2019

The npm is not updated.

@nifgraup nifgraup linked an issue Feb 14, 2020 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove Imap folder

2 participants