Convert to new IMixins and MixinsBuilder system #146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert to new IMixins registration system to have a unified system accross all mods, unified and more logging, it also provides "safer" registration with stronger checks regarding the target mods to validate the mixins.
As such I found two mixins that were not valid :
common_chickenchunks_MixinPlayerChunkViewerManagerwas declared as EARLY despite targeting a mod classI changed it to late, if that's a mistake and it needs to be early, then you need to declare a coremod class for Chicken chunks for the target mod to be detected at early time
the SHIPSMOD("cuchaz.ships") was used for early mixins but didn't have a coremod class declared, thus the mod could not be detected
Requires updating to unimixins 1.22