Dynamic sound loading #234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Phoenix-Starlight
force-pushed
the
dev/1.16/dynamic-sounds
branch
from
4213ea3 to
dca5bfc
Compare
embeddedt
reviewed
Sep 3, 2023
...ava/org/embeddedt/modernfix/common/mixin/perf/dynamic_resources/SoundBufferLibraryMixin.java
Outdated
Show resolved
Hide resolved
Phoenix-Starlight
force-pushed
the
dev/1.16/dynamic-sounds
branch
2 times, most recently
from
4ae9418 to
b2104ad
Compare
embeddedt
approved these changes
Sep 4, 2023
Owner
embeddedt
left a comment
embeddedt
left a comment
There was a problem hiding this comment.
I'll do some testing before merging it but looks reasonable.
Owner
|
Had another thought: is |
Contributor
Author
|
I was not aware that access would trigger removal, I was only
considering the pathological case where it tries to load more than 255 sounds (java channel limit).
|
If limit+1 sounds get loaded the buffer deletion can fail due to it being bound to a source but not played yet. Also fixes a leak.
Phoenix-Starlight
force-pushed
the
dev/1.16/dynamic-sounds
branch
from
ad7ae08 to
45ff248
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements dynamic sound (un)loading. Why? Because sound buffers are never unloaded and forever persist until exit or some trigger to release the buffers (reload).