Auto-generate mixin configs #305
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
I can test it easily by checking that it generates the same JSON as the previous approach. No victims required. |
Contributor
Author
|
RemapJar task originally didn't take the JSON. (Hence the hack into resource sourceset) |
Phoenix-Starlight
force-pushed
the
dev/1.16/migrate-client-mixins
branch
2 times, most recently
from
dd0a2c0 to
a18011f
Compare
Phoenix-Starlight
force-pushed
the
dev/1.16/migrate-client-mixins
branch
3 times, most recently
from
8a47f47 to
43dc5b7
Compare
Phoenix-Starlight
force-pushed
the
dev/1.16/migrate-client-mixins
branch
3 times, most recently
from
a9d2017 to
dab2570
Compare
Contributor
Author
|
Ready. (Merge conflicts incoming for later branches...) |
Phoenix-Starlight
force-pushed
the
dev/1.16/migrate-client-mixins
branch
from
8894482 to
9770d55
Compare
embeddedt
requested changes
Dec 22, 2023
...e/src/main/java/org/embeddedt/modernfix/forge/mixin/perf/async_locator/EyeOfEnderAccess.java
Outdated
Show resolved
Hide resolved
- Takes two compiler arguments: -ArootProject.name and an optional -Aproject.name
Use fabric mixin dependency Enable preview features for annotation processor only
- Prefer TypeElements over TypeMirrors - Add debug option to log classes that couldn't be loaded - Reorganize exception logging
Halt AP on exception
This reverts commit 1105830.
Dependency rework Remove class shunting hack
There is no way to prevent the relocator transformation so we depend on the unshadowed project that pulls the shadowed project Cleanup client validator shadow jar
Fix shadowed unbundled dependencies
Refactor AP detection
More cleanup and change equality checks
Phoenix-Starlight
force-pushed
the
dev/1.16/migrate-client-mixins
branch
from
1b5fd4b to
cfae648
Compare
embeddedt
requested changes
Dec 27, 2023
Owner
embeddedt
left a comment
embeddedt
left a comment
There was a problem hiding this comment.
Very good work; I'm very happy with this. Tested locally and the generated mixin list is identical to my original hack, except it properly splits client mixins into the client list.
I just have one last question before merging.
(At some point, we might consider moving this into a standalone plugin so that it can be used by other projects.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #297
1 (or 2?) ugly hack since AP output API doesn't have anything for resources
On the positive side, the directory scanning hack is dead.
Get victims to test whether or not it explodes@ClientOnlyMixin