Lag on first frame rendering Tinkers' Construct tools

Tested environment (all latest)

When mixin.dynamic_resources=true

[16:50:34] [Client thread/ERROR] [tconstruct-API]: Could not load multimodel tconstruct:tools/pickaxe.tcon#inventory
[16:50:34] [Client thread/ERROR] [tconstruct-API]: Could not load multimodel tconstruct:tools/shovel.tcon#inventory
[16:50:34] [Client thread/ERROR] [tconstruct-API]: Could not load multimodel tconstruct:tools/hatchet.tcon#inventory
[16:50:34] [Client thread/ERROR] [tconstruct-API]: Could not load multimodel tconstruct:tools/mattock.tcon#inventory
[16:50:34] [Client thread/ERROR] [tconstruct-API]: Could not load multimodel tconstruct:tools/kama.tcon#inventory
[16:50:34] [Client thread/ERROR] [tconstruct-API]: Could not load multimodel tconstruct:tools/hammer.tcon#inventory
[16:50:34] [Client thread/ERROR] [tconstruct-API]: Could not load multimodel tconstruct:tools/excavator.tcon#inventory
[16:50:34] [Client thread/ERROR] [tconstruct-API]: Could not load multimodel tconstruct:tools/lumberaxe.tcon#inventory
[16:50:34] [Client thread/ERROR] [tconstruct-API]: Could not load multimodel tconstruct:tools/scythe.tcon#inventory
[16:50:34] [Client thread/ERROR] [tconstruct-API]: Could not load multimodel tconstruct:tools/broadsword.tcon#inventory
[16:50:34] [Client thread/ERROR] [tconstruct-API]: Could not load multimodel tconstruct:tools/longsword.tcon#inventory
[16:50:34] [Client thread/ERROR] [tconstruct-API]: Could not load multimodel tconstruct:tools/rapier.tcon#inventory
[16:50:34] [Client thread/ERROR] [tconstruct-API]: Could not load multimodel tconstruct:tools/frypan.tcon#inventory
[16:50:34] [Client thread/ERROR] [tconstruct-API]: Could not load multimodel tconstruct:tools/battlesign.tcon#inventory
[16:50:34] [Client thread/ERROR] [tconstruct-API]: Could not load multimodel tconstruct:tools/cleaver.tcon#inventory
[16:50:34] [Client thread/ERROR] [tconstruct-API]: Could not load multimodel tconstruct:tools/shortbow.tcon#inventory
[16:50:34] [Client thread/ERROR] [tconstruct-API]: Could not load multimodel tconstruct:tools/longbow.tcon#inventory
[16:50:34] [Client thread/ERROR] [tconstruct-API]: Could not load multimodel tconstruct:tools/arrow.tcon#inventory
[16:50:34] [Client thread/ERROR] [tconstruct-API]: Could not load multimodel tconstruct:tools/crossbow.tcon#inventory
[16:50:34] [Client thread/ERROR] [tconstruct-API]: Could not load multimodel tconstruct:tools/bolt.tcon#inventory
[16:50:34] [Client thread/ERROR] [tconstruct-API]: Could not load multimodel tconstruct:tools/shuriken.tcon#inventory
[16:50:35] [Client thread/ERROR] [tconstruct-API]: Could not load material model tconstruct:parts/tough_tool_rod.tmat#inventory
[16:50:35] [Client thread/ERROR] [tconstruct-API]: Could not load material model tconstruct:parts/scythe_head.tmat#inventory
[16:50:35] [Client thread/ERROR] [tconstruct-API]: Could not load material model tconstruct:parts/tough_binding.tmat#inventory
[16:50:35] [Client thread/ERROR] [tconstruct-API]: Could not load material model tconstruct:parts/broad_axe_head.tmat#inventory
[16:50:35] [Client thread/ERROR] [tconstruct-API]: Could not load material model tconstruct:parts/large_plate.tmat#inventory
[16:50:36] [Client thread/ERROR] [tconstruct-API]: Could not load material model tconstruct:parts/tool_rod.tmat#inventory
[16:50:36] [Client thread/ERROR] [tconstruct-API]: Could not load material model tconstruct:parts/shovel_head.tmat#inventory
[16:50:36] [Client thread/ERROR] [tconstruct-API]: Could not load material model tconstruct:parts/binding.tmat#inventory
[16:50:37] [Client thread/ERROR] [tconstruct-API]: Could not load material model tconstruct:parts/pick_head.tmat#inventory

mixin.dynamic_resources=false (Just like when you don't have this mod installed)

This has little effect in normal environments, but in large modpacks, it will cause a few seconds of freeze every time the Tool Forge GUI is opened

[jchung01]

Sorry if this isn't quite related to the issue, but you can see similar issues while searching through HEI. There aren't any texture issues in HEI anymore as far as I can tell. However, when HEI needs to render tinker's tools, depending on how many it needs to render, you can experience brief moments of freezing and the same types of errors are printed. I would assume it's because tinker's uses item model overrides and those aren't pre-baked by the dynamic resources functionality?

[embeddedt]

Most likely.

Sorry if this isn't quite related to the issue, but you can see similar issues while searching through HEI. There aren't any texture issues in HEI anymore as far as I can tell. However, when HEI needs to render tinker's tools, depending on how many it needs to render, you can experience brief moments of freezing and the same types of errors are printed. I would assume it's because tinker's uses item model overrides and those aren't pre-baked by the dynamic resources functionality?

I also encountered this problem

[Krutoy242]

The issue is still actual and i would really appreciate fix!

[embeddedt]

I assume most people experiencing this issue have CensoredASM installed. Does it help to disable releaseSpriteFramesCache in its config?

[Krutoy242]

I assume most people experiencing this issue have CensoredASM installed. Does it help to disable releaseSpriteFramesCache in its config?

For the test, i set releaseSpriteFramesCache=false, reloaded game and opened Tool Forge - still freeze for few seconds, as without config change.

[Keaft]

I can also confirm that disabling releaseSpriteFramesCache through FermiumASM (ultimately a fork of CensoredASM) and Binkers Bonstruct does not reduce freezing from this error.

Interestingly, reverting back to FoamFix removes the errors, but I'm still getting freezes slightly less, but still severe. The freezing on VintageFix is much longer.

There are a significant amount of errors, the last of them in this log are related to the issue (with more detail) as I click through all the item pages on HEI. There is a crash that'll list all the mods a little ways up from the bottom. None of the errors restrict continuing to play.
latest.log

If you'd like an environment that'll generate this consistently, let me know!

SlimeKnights/TinkersConstruct#3651 suggests this may be a long standing issue?

Edit: As referenced in my latest.log above:

net.minecraftforge.client.model.ModelLoaderRegistry$LoaderException: Exception loading model tconstruct:fluid_block#uranium with loader VariantLoader.INSTANCE
	at org.embeddedt.vintagefix.dynamicresources.model.DynamicModelProvider.loadModel(DynamicModelProvider.java:208) ~[DynamicModelProvider.class:?]
etc
etc
etc...
Caused by: java.lang.NullPointerException
	at net.minecraftforge.client.model.ModelLoader$MultipartModel.<init>(ModelLoader.java:1212) ~[ModelLoader$MultipartModel.class:?]
	at net.minecraftforge.client.model.ModelLoader$VariantLoader.loadModel(ModelLoader.java:1345) ~[ModelLoader$VariantLoader.class:?]
	at org.embeddedt.vintagefix.dynamicresources.model.DynamicModelProvider.loadModel(DynamicModelProvider.java:206) ~[DynamicModelProvider.class:?]

I set VintageFix's mixin.dynamic_resources to false and it's freezing behavior now mimics that of FoamFix where it's still severe, but not nearly as severe.

[embeddedt]

In the latest beta I have applied many optimizations to both the Forge model baking pipeline and Tinkers itself. Please try it and let me know if the lag spike is less severe. (Please also let me know if the optimizations cause any models to render incorrectly compared to before.)

https://nightly.link/embeddedt/VintageFix/workflows/gradle/main/Package.zip

@embeddedt I got a crash when updating to the latest build
https://mclo.gs/on4tGKH

[embeddedt]

Can you provide the full log please?

[embeddedt]

Update: got a full log from another user with the same crash, and pushed a fix.