-
Notifications
You must be signed in to change notification settings - Fork 6
Adds awsPrefix config #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds awsPrefix config #3
Conversation
return data from log statements for testing purposes
|
Hi @noslouch and thanks for adding this 👍 . Looks great! Can you please add tests for the changes you made? Happy to merge this in with tests. |
|
can do! |
|
hey @LevelbossMike! I added a couple assertions for uploading and activating. Let me know if that's ok, or if you'd also like to assert against revision fetching as well. |
|
@noslouch This looks very nice 🎉 Yes please also add a test that listing works as expected when using a prefix. |
|
All righty. I had to tweak the signature of |
|
cool! thx so much! |
|
you're welcome! any chance you can cut a release today at some point? |
|
@noslouch this is released now via 0.0.3 |
|
Excellent! Thanks so much! |
Most of the other S3 ember-cli-deploy plugins include a configuration to add prefix to files destined for an S3 bucket, e.g. to upload stuff to a nested path. This PR adds that config option, and a couple other items I noticed while digging around in the source.
_listregex. the regex in_listwasn't matching some revision keys due to including[^.]*in the pattern.ember-cli-deploy-revision-datauses version numbers and a commit hash by default in the form of#.#.#+<hash>, which means the literal.characters will fail the regex test. I changed the regex to match any character betweenarchivePrefixand.zip. I think the fact that the pattern also includes.zipshould ensure that it only matches zipped asset bundles.