Skip to content

Update config around production-like environments#100

Merged
LevelbossMike merged 1 commit intomasterfrom
unknown repository
Mar 13, 2015
Merged

Update config around production-like environments#100
LevelbossMike merged 1 commit intomasterfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Mar 13, 2015

I understand stuff is changing real soon with #59 but I was struggling with getting staging setup to behave exactly like production in terms of fingerprinting, minifying etc right now.

There are a number of other options that are required in ember-cli if a build exactly the same as --environment production is desired, which i've now added to the readme.

@LevelbossMike
Copy link
Copy Markdown
Member

Thanks for improving the README! Unfortunately this is still a pain to do in ember-cli and also other addons are a problem with this approach because they can't be forced to add productionLike assets via the app's Brocfile (ember-faker is an example). Bloats the build but does not change the app's behaviour much of course.

Would be great if you could also add the vendorFiles-property which is needed to add the production like builds for handlebars and ember itself for vendor.js:

  vendorFiles: {
    'handlebars.js': {
      staging:  'bower_components/handlebars/handlebars.runtime.js'
    },
    'ember.js': {
      staging:  'bower_components/ember/ember.prod.js'
    }

@ghost
Copy link
Copy Markdown
Author

ghost commented Mar 13, 2015

Think there's a bunch of issues in the ember-cli repo around multiple environments so hopefully there will be a simpler solution soon.

Just pushed up the vendorFiles addition.

@ghost
Copy link
Copy Markdown
Author

ghost commented Mar 13, 2015

Actually, is adding vendorFiles necessary? Adding it breaking ember build for me.

@ghost
Copy link
Copy Markdown
Author

ghost commented Mar 13, 2015

Ah I don't have handlebars.

LevelbossMike added a commit that referenced this pull request Mar 13, 2015
Update config around production-like environments
@LevelbossMike LevelbossMike merged commit 4c908ec into ember-cli-deploy:master Mar 13, 2015
@LevelbossMike
Copy link
Copy Markdown
Member

Thx again! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants