Skip to content

Deprecated commands no longer needed.#56

Merged
lukemelia merged 2 commits intomasterfrom
50-deprecate-old-commands
Feb 28, 2015
Merged

Deprecated commands no longer needed.#56
lukemelia merged 2 commits intomasterfrom
50-deprecate-old-commands

Conversation

@achambers
Copy link
Copy Markdown
Member

Deprecated the following commands:

  • ember deploy:index
  • ember deploy:assets

As well as commands from the former ember-cli-project:

  • ember activate
  • ember deploy:versions

Closes #50

@achambers achambers force-pushed the 50-deprecate-old-commands branch from dd762de to d10e3cf Compare February 28, 2015 14:53
Also added deprecated commands for those that could be used by users
of the project formerly known as `ember-cli-deploy`
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: "deprecated" means still works but will be removed in the future. We should probably refer to this as "no longer supported"

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, good point.

@achambers achambers force-pushed the 50-deprecate-old-commands branch from d10e3cf to 1671773 Compare February 28, 2015 14:54
@lukemelia
Copy link
Copy Markdown
Contributor

How will this work with ember help? Ideally these commands would not appear. Is that possible?

@achambers
Copy link
Copy Markdown
Member Author

@lukemelia I modify the command descriptions to add [NO LONGER SUPPORTED] in red text. So it looks something like this:

ember activate <options...>
[NO LONGER SUPPORTED] Activate a deployed version of index.html

I'd need to look deeper into how ember-cli creates the commands but I imagine, to remove them from ember help would mean that they can't be executed. Which kind of defeats the purpose of adding the message in the first place.

@lukemelia
Copy link
Copy Markdown
Contributor

@achambers sounds good. doesn't look like ember-cli has a way to hide a command from help.

lukemelia added a commit that referenced this pull request Feb 28, 2015
Deprecated commands no longer needed.
@lukemelia lukemelia merged commit 4e0128b into master Feb 28, 2015
@lukemelia lukemelia deleted the 50-deprecate-old-commands branch February 28, 2015 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add deprecation warnings for former ember-cli-deploy commands

2 participants