Deprecate use of deploy.json in favor of config/deploy.js. Closes #51#57
Conversation
lukemelia
commented
Feb 28, 2015
lukemelia
commented
- introduces a deprecate util
- provides the ConfigurationReader with the ui instance
- improves error message when config file is missing
- changes default value for --deploy-config-file option
- updates README
…er-cli-deploy#51 * introduces a deprecate util * provides the ConfigurationReader with the ui instance * improves error message when config file is missing * changes default value for --deploy-config-file option * updates README
lukemelia
force-pushed
the
deploy-json-deprecation
branch
from
789e067 to
4de84a3
Compare
|
do I remember us saying we will eventually also support per-env files? |
|
code looks great to me. What's customary here, should I actually pull down and try it? Or are the tests supposed to handle the behavior? |
|
I believe it was agreed in one of the issues that we'd just have a single deploy.js file @samselikoff . |
|
@samselikoff - issue #46 has some comments regarding per env configs. Regarding what is customary - I do what is necessary for me to be comfortable 👍 the PR. Sometimes I pull down code to verify and probe around some use cases I'm unsure are handled. Usually however, I'm good to read through the code and don't need to pull it down and review. |
|
Tests should handle it. We should have a manual smoke test as part of our release process. If we make a mistake, we will fix or revert. Someone go ahead and press the big green button. |
|
👍 - I can't press the big green button but it looks good to me |
|
@danshultz just invited you to the team |
Deprecate use of deploy.json in favor of config/deploy.js. Closes #51
|
Thanks PR merged |
4 participants
