Fix regression to the type of object that was being passed to assets adapters as “config”.#63
Merged
LevelbossMike merged 1 commit intoember-cli-deploy:masterfrom Mar 1, 2015
Conversation
Member
|
@lukemelia I merged PR #64 first, so might be worth a rebase of this one. |
…adapters as “config”. Closes ember-cli-deploy#62 * Slight refactoring to AssetsTask to make it’s interaction with AssetsUploader more testable * this change means we are not being as lazy with default values as before. That’s ok. * ConfigurationReader now needs to be constructed with a project reference
lukemelia
force-pushed
the
62-config-refression
branch
from
ada0bec to
a8afaa3
Compare
Contributor
Author
|
Rebased |
LevelbossMike
added a commit
that referenced
this pull request
Mar 1, 2015
Fix regression to the type of object that was being passed to assets adapters as “config”.
Member
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix regression to the type of object that was being passed to assets adapters as “config”. Closes #62