npm post install message for users of v0.0.6#85
Merged
lukemelia merged 2 commits intoember-cli-deploy:masterfrom Mar 7, 2015
Merged
npm post install message for users of v0.0.6#85lukemelia merged 2 commits intoember-cli-deploy:masterfrom
lukemelia merged 2 commits intoember-cli-deploy:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Not sure if there is a better way to get to the user's home directory or not but also, shouldn't this be in the following format to handle different platform path spacing (not sure if that matters in our current scenario or not)
path.join(__dirname, '..', '..', '..', '..', 'config', 'deploy', '*.js');
Member
Author
There was a problem hiding this comment.
Yeh, I'm not sure if there is a better way either mate. That's actually the main reason I put it out there to you guys.
Will make the change to the path.join.
There was a problem hiding this comment.
I'm fairly certain that path.join will normalize the '/' for you, so there's no need to artificially break the segments up as separate arguments. And indeed, I confirmed this is so (at least on Win11/Node 0.10 and 0.12)
This message is fired only for users that seem to have config from `v0.0.6`. For these users the message will be displayed everytime they run an ember-cli-deploy command
achambers
force-pushed
the
70-npm-post-install-message
branch
from
78dc9f1 to
82cca5f
Compare
lukemelia
added a commit
that referenced
this pull request
Mar 7, 2015
npm post install message for users of v0.0.6
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
MIGRATION_STEPS.mdfile containing migration instructions for users ofv0.0.6.postinstallscript that warns users upgrading fromv0.0.6and points them to the migration instructionsv0.0.6Closes #69 and #70