[BUGFIX] execSync compat issue #92

[joebartels]

branch is intended to resolve issues around child_process execSync compatibility among the nodejs versions and platforms it's installed on. sync-exec is a good candidate. Another possible sol'n is latest version of execSync as noted by @duizendnegen in #92

This PR uses sync-exec and was confirmed to resolve #92 and is a potential fix for #90

[lukemelia]

@joebartels Thanks for working on this. In the test, it looks like what you are stubbing doesn't match the usage. I think this is the source of the failure? Can you fix?

[joebartels]

@lukemelia thanks for the feedback. I've updated how the sha test builds a stub for sync-exec and refactored createTag to work with how I changed the test... not proud of doing it like this. The other alternative I considered was instead of hardcoding a sha1 value in the sha test, it could be created from the actual git rev-parse HEAD at test runtime. e.g.,

// sha-test.js
var syncExec = require('sync-exec');
...
var GIT_SHA = syncExec('git rev-parse HEAD').stdout;

then no sandboxing is required for sync-exec. Although since it wasn't done this way I decided against it. Open to any suggestions (or PRs) :)

[joebartels]

or create a utility, utilities/sync-exec.js that exports an object with the function require('sync-exec') as a method, that way it can be stubbed nicely for testing: joebartels@fceeca3

[lukemelia]

Left you a PR @joebartels

[lukemelia]

@joebartels After you merge my PR, go ahead and squash it down to one commit with a descriptive message, and I'll merge it in the morning.

[joebartels]

👍 really appreciate the help @lukemelia