Adding new navbar (using ember-styleguide) and footer #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
app/styles/app.scss
Outdated
| margin-left: -60px; | ||
| } | ||
|
|
||
| @import "ember-bootstrap/bootstrap"; |
There was a problem hiding this comment.
Please remove this, as the necessary styles are already included in styleguide.
package.json
Outdated
| "deploy": "ember deploy production" | ||
| }, | ||
| "devDependencies": { | ||
| "bootstrap-sass": "^3.3.7", |
There was a problem hiding this comment.
Should be able to remove both bootstrap deps from package.json
mansona
changed the title
|
We still have some styles to fix for the navbar, but functionally, this should be good to go. |
|
Thanks so much @mansona @rwwagner90 ❤️ You guys rock! |
serenaf
approved these changes
Feb 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wow, what an amazing day 🎉 I am completely surprised what we have been able to achieve on this PR and I feel incredibly grateful being able to work with such awesome people 😍
This is now ready for review, so let's get this merged 💪