Clean up logo code
#127
Merged
Clean up logo code
#127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexlafroscia
commented
Mar 26, 2018
| logo = 'ember-cli'; | ||
| } else if (name.match('ember-data-')) { | ||
| logo = 'ember-data'; | ||
| } else if (name.match('ember-data-')) { |
Contributor
Author
There was a problem hiding this comment.
This was using ember-data- twice which didn't make sense
alexlafroscia
commented
Mar 26, 2018
|
|
||
| return logo; | ||
| }), | ||
| addonLogo: addonLogo(packageJson), |
Contributor
Author
There was a problem hiding this comment.
Unsure if you prefer passing packageJson into the CP macro or would rather this.get('packageJson') within the CP definition. I like this API better since it makes less assumptions about that packgeJson property being available.
This also updates the implementation to match the documentation
Contributor
|
This is great - thank you dude! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs-headerused theaddonLogoproperty, all other references to the same feature uselogo. The documentation also usedlogobut the implementation was settingaddonLogoand ignoring the providedlogoproperty. Now it's all justlogo