Skip to content

Add Ember 2.8 to ember-try config #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 9, 2018
Merged

Add Ember 2.8 to ember-try config #145

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,8 @@ jobs:
script: yarn test:node

- stage: versioned tests
env: EMBER_TRY_SCENARIO=ember-lts-2.12
env: EMBER_TRY_SCENARIO=ember-lts-2.8
- env: EMBER_TRY_SCENARIO=ember-lts-2.12
- env: EMBER_TRY_SCENARIO=ember-lts-2.16
- env: EMBER_TRY_SCENARIO=ember-release
- env: EMBER_TRY_SCENARIO=ember-beta
Expand Down
4 changes: 2 additions & 2 deletions addon/components/docs-viewer/x-nav/template.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
</div>
{{/if}}

<nav {{action (mut isShowingMenu) false}}
<nav onclick={{action (mut isShowingMenu) false}}
class='
absolute pin-r lg:relative bg-white shadow-lg lg:shadow-none
w-90% px-3 lg:px-0 z-10 lg:w-1/5 flex-no-shrink transition
Expand All @@ -20,7 +20,7 @@
<div class='pt-px sticky pin-t mb-8 '>
{{#if (or media.isMobile media.isTablet)}}
<div class="text-right">
<button {{action (mut isShowingMenu) false}}
<button onclick={{action (mut isShowingMenu) false}}
class='text-grey-darkest opacity-50 hover:opacity-100 text-3xl py-2 no-underline'>
&times;
</button>
Expand Down
11 changes: 11 additions & 0 deletions config/ember-try.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,17 @@ module.exports = function() {
name: 'node',
command: 'yarn test:node'
},
{
name: 'ember-lts-2.8',
bower: {
dependencies: {
'ember': 'components/ember#lts-2-8'
},
resolutions: {
'ember': 'lts-2-8'
}
},
},
{
name: 'ember-lts-2.12',
npm: {
Expand Down