Omit <a> title attribute if title is null #240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Contributor
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tweaks the
title()method of theHBSRendererin lib/utils/compile-markdown.js to only add a title attribute to the html snippet when the passedtitleargument is truthy.This prevents adding
null(and perhaps alsoundefined, but I haven't encountered that yet) title attributes toatags, such as this (visible here):This PR also bumps the
markeddependency from^0.3.12to^0.5.0for no particular reason other than to keep it up to date - I don't feel strongly about this and I'm happy to remove this change from the PR if you'd prefer.