Updates ember-keyboard configurations to be more flexible #288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This could probably use some documentation around which components support which shortcuts, I'm just not sure the best location / format for that. |
Member
|
@samselikoff @pzuraq any reason not to merge this? It looks good to me. |
RobbieTheWagner
approved these changes
Jul 31, 2019
Contributor
|
Looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #263
addon/controllers/application.jsbecause it seems like it's duplicatingdocs-keyboard-shortcutsember-keyboardto default the keyboardActivated property to true instead of setting in the init methods so users can optionally render those components with it set to false.