minor changes to runloop #2146
Merged
minor changes to runloop #2146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for ember-guides failed.
|
kategengler
reviewed
Sep 14, 2025
| {{this.aspectRatio}} | ||
| ```gjs | ||
| <template> | ||
| {{this.width}} |
Contributor
There was a problem hiding this comment.
This example was weird to begin with -- the Image class isn't a component or controller that could back a template.
Member
Author
There was a problem hiding this comment.
I fixed it in a way that will allow us to move forward for now 👍 I think this whole page is questionable but I don't want it to be a blocker of merging the GJS branch
kategengler
reviewed
Sep 14, 2025
kategengler
approved these changes
Sep 15, 2025
IgnaceMaes
approved these changes
Sep 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was only one template in here but there are 2 other changes that I made to this file. I am targeting gjs to prevent confusion 👍
Changes:
<template/>(this is probably overkill but it's also just fine)