Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
68 changes: 68 additions & 0 deletions learning-team/2021-05/2021-05-13.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,68 @@
# May 13, 2021

Facilitator & Note Taker: AL

## Attendees

Add yourself to the list if you attend and check the box!

### Core Team

- [x] Amy Lam (AL)
- [x] Chris Manson (CM)
- [ ] Isaac Lee (IL)
- [x] Jared Galanis (JG)
- [x] Jen Weber (JW)
- [ ] Jessica Jordan (JJ)
- [ ] Kenneth Larsen (KL)
- [x] Ricardo Mendes (RM)
- [ ] Robert Wagner (RW)

### Guests

- [] Your name here (INITIALS)

## Weekly review

### Review action items (weekly)

See: [Action items board](https://github.com/orgs/ember-learn/projects/47)

- Check.

### Review Initiatives board (every other week)

See: [Initiatives board](https://github.com/orgs/ember-learn/projects/33)

- These are from 2020. We will revisit this topic later in the meeting.

### Review PR queue

See: [tracking sheet](https://docs.google.com/spreadsheets/d/1sPyN9z9wZMpTNwqCfa6R9QSPZkIW4iQd-H4gZC7ILLk/edit#gid=2035777454)

- https://github.com/ember-learn/ember-styleguide/pull/395, needs discussion. Can revisit next week to see if anything happens.
- We merged the cli-guides one: https://github.com/ember-learn/cli-guides/pull/226.

## Topics

### https://github.com/ember-learn/ember-api-docs/pull/755 Heroku woes, ember-api-docs hasn't been deployed in a year. (AL, 5? Can also track down who best to ping.)

- CM says Heroku's Ember build pack is broken. We cannot depend on Heroku's build pack. A fork of Heroku has worked for Ember Fastboot...but has a rolling memory leak problem. `ember-learn/ember-api-docs` is just the frontend of the "ember-api-docs" suite of repos. RM has more context on the issue and AL filled in on what she chatted with Heroku / Siva. JW asks do we have to use Heroku?
- RM said the code itself is the usual DSL stuff. Something about a version of Ruby that is supposed to be embedded.
- CM will add to the Fastboot agenda. Way forward is to stop using the Ember buildpack. CM will ask the Fastboot working group how best to do that and see if will get some progress on that. The solution (theoretically) is to use the Node buildpack instead of the Ember buildpack, which will run a `npm build` and `npm start`. But that is not enough for a Fastbooted Ember app to be considered Ember ready. Then add it to the Fastboot docs. Fastbook PR for ref: https://github.com/ember-fastboot/fastboot-website/pull/116
- What the PR is doing is fixing if Glimmer segments have 2 or more slashes, they 404 in production.
- [ ] Action item: AL will drop the Heroku testing commits and merge the PR, then create a new PR to fix Heroku stuff.
- JW can we deploy the ember-api-docs thru AWS or something? Perhaps through GitHub sponsorship? We can't be in a non-deploying state in 4.0.
- [ ] Action item: CM and RM will meet and talk about this next Thursday.

### ember-json-api-docs

- [ ] Action item for next release: Heroku-related: JW says there has been some bug fixes to ember-json-api-docs, but a fix from lifeart (https://github.com/ember-learn/ember-jsonapi-docs/pull/97) was missing. Can we be sure to do a pull in the next release? RM checked out the tool code (https://github.com/ember-learn/tool-new-release), which now clones from GitHub, so we're not sure why it didn't pull. Perhaps can do it once locally to fix old generated docs and ensure that ember-jsonapi-docs/pull/97 gets in?

## Ember Times suggestions

Add writeup ideas / call for contributors / suggestions to [the latest PR](https://github.com/ember-learn/ember-blog/pulls?q=is%3Aopen+is%3Apr+label%3A%22%F0%9F%97%9E+embertimes%22%20or%20#support-ember-times) or [#support-ember-times](https://discordapp.com/channels/480462759797063690/485450546887786506) on Discord.

## Any Questions?

Questions, comments or concerns? Submit a comment or PR for this set of notes.