[BUGFIX release] loosemode interop not working with renderComponent #20994
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NullVoxPopuli
changed the title
Estimated Asset SizesDiff --- main/out.txt 2025-10-13 19:57:14.000000000 +0000
+++ pr/./pr-18722209612/out.txt 2025-10-22 15:58:24.000000000 +0000
@@ -1,41 +1,41 @@
╔═══════╤═══════════╤═══════════╗
║ │ Min │ Gzip ║
╟───────┼───────────┼───────────╢
-║ Total │ 417.63 KB │ 231.54 KB ║
+║ Total │ 417.63 KB │ 231.59 KB ║
╚═══════╧═══════════╧═══════════╝
-╔══════════════════════╤═══════════╤═══════════╗
-║ @ember/* │ Min │ Gzip ║
-╟──────────────────────┼───────────┼───────────╢
-║ Total │ 238.38 KB │ 146.55 KB ║
-╟──────────────────────┼───────────┼───────────╢
-║ -internals │ 34.55 KB │ 24.85 KB ║
-║ application │ 12.71 KB │ 7.66 KB ║
-║ array │ 12.66 KB │ 7.32 KB ║
-║ canary-features │ 304 B │ 419 B ║
-║ component │ 1.07 KB │ 963 B ║
-║ controller │ 1.8 KB │ 1.36 KB ║
-║ debug │ 11.4 KB │ 7.92 KB ║
-║ deprecated-features │ 31 B │ 77 B ║
-║ destroyable │ 561 B │ 383 B ║
-║ enumerable │ 259 B │ 387 B ║
-║ helper │ 823 B │ 609 B ║
-║ instrumentation │ 2.43 KB │ 1.78 KB ║
-║ modifier │ 669 B │ 605 B ║
-║ object │ 33.78 KB │ 20.79 KB ║
-║ owner │ 159 B │ 178 B ║
-║ renderer │ 406 B │ 349 B ║
-║ routing │ 58.08 KB │ 33.44 KB ║
-║ runloop │ 2.2 KB │ 1.33 KB ║
-║ service │ 859 B │ 741 B ║
-║ template │ 430 B │ 357 B ║
-║ template-compilation │ 429 B │ 366 B ║
-║ template-compiler │ 57.91 KB │ 30.4 KB ║
-║ template-factory │ 94 B │ 160 B ║
-║ test │ 923 B │ 627 B ║
-║ utils │ 3.93 KB │ 3.5 KB ║
-║ version │ 55 B │ 131 B ║
-╚══════════════════════╧═══════════╧═══════════╝
+╔══════════════════════╤═══════════╤══════════╗
+║ @ember/* │ Min │ Gzip ║
+╟──────────────────────┼───────────┼──────────╢
+║ Total │ 238.38 KB │ 146.6 KB ║
+╟──────────────────────┼───────────┼──────────╢
+║ -internals │ 34.55 KB │ 24.85 KB ║
+║ application │ 12.71 KB │ 7.63 KB ║
+║ array │ 12.66 KB │ 7.32 KB ║
+║ canary-features │ 304 B │ 419 B ║
+║ component │ 1.07 KB │ 1018 B ║
+║ controller │ 1.8 KB │ 1.36 KB ║
+║ debug │ 11.4 KB │ 7.92 KB ║
+║ deprecated-features │ 31 B │ 77 B ║
+║ destroyable │ 561 B │ 383 B ║
+║ enumerable │ 259 B │ 387 B ║
+║ helper │ 823 B │ 610 B ║
+║ instrumentation │ 2.43 KB │ 1.78 KB ║
+║ modifier │ 669 B │ 601 B ║
+║ object │ 33.78 KB │ 20.79 KB ║
+║ owner │ 159 B │ 178 B ║
+║ renderer │ 406 B │ 346 B ║
+║ routing │ 58.08 KB │ 33.45 KB ║
+║ runloop │ 2.2 KB │ 1.33 KB ║
+║ service │ 859 B │ 741 B ║
+║ template │ 430 B │ 388 B ║
+║ template-compilation │ 429 B │ 366 B ║
+║ template-compiler │ 57.91 KB │ 30.4 KB ║
+║ template-factory │ 94 B │ 160 B ║
+║ test │ 923 B │ 627 B ║
+║ utils │ 3.93 KB │ 3.5 KB ║
+║ version │ 55 B │ 131 B ║
+╚══════════════════════╧═══════════╧══════════╝
╔═════════════════╤═══════════╤══════════╗
║ @glimmer/* │ Min │ Gzip ║Details
|
NullVoxPopuli
commented
Oct 22, 2025
packages/@ember/-internals/glimmer/tests/integration/components/render-component-test.ts
Outdated
Show resolved
Hide resolved
Fix for the failing test -- turns out we don't need a StrictResolver Also add the reverse test so we don't accidentally enable loosemode in strict components.
NullVoxPopuli
force-pushed
the
nvp/renderComponent/loose-mode-interop-not-working
branch
from
4c666da to
ec579cf
Compare
NullVoxPopuli
changed the title
|
there seems to be also something else going on - in the original repro, the corrected code now passes the first call to renderComponent, but the second one, even if it's the same render function call, explodes again with |
|
yeah, that is indeed a separate issue -- worthy of a separate PR and repro -- and one that I haven't been able to repro myself consistently. Lets chat in discord about how to re-create that error |
NullVoxPopuli
deleted the
nvp/renderComponent/loose-mode-interop-not-working
branch
kategengler
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't need a
StrictResolver, because there is no resolving in strict mode.The resolver that is constructed for the strict renderer is what is used for the whole of that rendering tree.
When a strict-mode component encounters something not in the scope bag, it throws a compile-time syntax error -- so resolution never occurs.
Big thanks to @vlascik for reporting and providing a repro