Skip to content

Remove deprecated TypeScript compiler options for TS 6.0 compatibility #21004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 21, 2025
Merged

Remove deprecated TypeScript compiler options for TS 6.0 compatibility #21004

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5266e44
Initial plan
Copilot Nov 13, 2025
af01e02
Remove deprecated TypeScript compiler options
Copilot Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@
"terser": "^5.42.0",
"testem": "^3.10.1",
"testem-failure-only-reporter": "^1.0.0",
"typescript": "5.2",
Copy link
Contributor

@NullVoxPopuli NullVoxPopuli Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot this change is not needed, please revert

Copy link
Member

@kategengler kategengler Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure you have any control if I opened it with copilot...

"typescript": "5.2.2",
"typescript-eslint": "^8.26.0",
"vite": "^5.4.12"
},
Expand Down Expand Up @@ -403,4 +403,4 @@
}
},
"packageManager": "pnpm@10.5.0"
}
}
6 changes: 4 additions & 2 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 0 additions & 2 deletions tsconfig/compiler-options.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,6 @@
"noUnusedLocals": false,
"noUncheckedIndexedAccess": true,
"noUnusedParameters": true,
"esModuleInterop": false,
Copy link
Contributor

@NullVoxPopuli NullVoxPopuli Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot please revert this.

Same reasoning as here: https://github.com/emberjs/ember.js/pull/21004/files#r2525083129

Copy link
Contributor

@NullVoxPopuli NullVoxPopuli Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot I'll let you keep it if you comment it out, and explain why we want the "false" value

"allowSyntheticDefaultImports": false,
Copy link
Contributor

@NullVoxPopuli NullVoxPopuli Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot this is a correctness thing.

Please do not change this.

Read the docs from here: https://www.typescriptlang.org/tsconfig/#allowSyntheticDefaultImports

As you can, see, it makes default exports be the same as namespace exports -- which is wrong. As library authors, we must be good stewards of the ecosystem, and not push instability on to our consumers.

Copy link
Contributor

@NullVoxPopuli NullVoxPopuli Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot I'll let you keep it if you comment it out, and explain why we want the "false" value

Copy link
Member

@kategengler kategengler Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NullVoxPopuli What tests can you write to keep these changes from being made? I very well may have done the same listening to the errors from the TS nightly job.

Copy link
Contributor

@NullVoxPopuli NullVoxPopuli Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for ESM? naw.

we can only make a repro if you we try to import CJS, which can't happen in the browser

"isolatedModules": true,

"newLine": "LF",
Expand Down