Skip to content
This repository was archived by the owner on May 26, 2019. It is now read-only.

Conversation

bf4
Copy link

@bf4 bf4 commented Mar 30, 2015

stubbing something for discussion

@bf4
Copy link
Author

bf4 commented Jun 3, 2015

@mitchlloyd @rwjblue any feedback on what should go in the guides here appreciated. I haven't actually used a service before.

@mitchlloyd
Copy link
Contributor

@bf4 Reading over the current document, it seems like there needs to be a pretty big overhaul. Probably the documentation needs to go something like this:

  • What is dependency injection?
  • What is a service and what is it good for? (use cases, audio example in here is good but needs to be updated to use a service and not use render)
  • Using Ember.inject to inject services (and controllers I suppose)
  • Ember's register & inject (what is there appears valid)

@bf4
Copy link
Author

bf4 commented Jun 4, 2015

@mitchlloyd If you're up to writing it, I can close this. I really just wanted to start a discussion and maybe learn a thing or two.

I don't think I have enough context or experience to expand on your bullet points in any useful way. 😄 If you want to collaborate in code, I suppose you can open a PR into my branch.

@mitchlloyd
Copy link
Contributor

I think there just needs to be an issue to document services if there isn't
one already. I have had many people ask me "where are services documented"?
On Thu, Jun 4, 2015 at 8:23 AM Benjamin Fleischer notifications@github.com
wrote:

@mitchlloyd https://github.com/mitchlloyd If you're up to writing it, I
can close this. I really just wanted to start a discussion and maybe learn
a thing or two.

I don't think I have enough context or experience to expand on your bullet
points in any useful way. [image: 😄] If you want to collaborate in
code, I suppose you can open a PR into my branch.


Reply to this email directly or view it on GitHub
#148 (comment).

@bf4
Copy link
Author

bf4 commented Jun 4, 2015

I decided to make the issue as a PR in case that it was close to what I wrote that I could take it home. (I also prefer PRs to 'hey could you do this?' :)

@locks
Copy link
Contributor

locks commented Jul 10, 2015

@bf4 can you close this? like @mitchlloyd commented it's not a light undertaking and it's easier to coordinate internally

@bf4 bf4 closed this Jul 10, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants