Fix offset by 1 when computing gradient fill color #130
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The gradient fill color for point N was incorrectly computed using the coordinates of point N+1. In adition, the corner case where the line crossed the reference line was also handled incorrectly.
This caused a visible offset, as shown in the screenshot below (notice how the line color and the fill color do not match).
With this fix, the line and fill colors now match exactly:
Code used for the screenshots