Skip to content

Create wrappers for llvm-dwp and llvm-nm #14659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 17, 2021
Merged

Create wrappers for llvm-dwp and llvm-nm #14659

merged 1 commit into from
Jul 17, 2021

Conversation

sbc100
Copy link
Collaborator

@sbc100 sbc100 commented Jul 15, 2021 •
edited
Loading

Fixes: #14533

@sbc100 sbc100 requested a review from kripken July 15, 2021 00:01
kripken
kripken approved these changes Jul 15, 2021
View reviewed changes
Copy link
Member

@kripken kripken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't feel strongly, but maybe we could avoid the hyphen for now, and convert them all to hypthens at some future time?

@sbc100 sbc100 changed the title Create wrapper for llvm-dwp and llvm-nm Create wrappers for llvm-dwp and llvm-nm Jul 16, 2021
@sbc100
Copy link
Collaborator Author

sbc100 commented Jul 16, 2021

I don't feel strongly, but maybe we could avoid the hyphen for now, and convert them all to hypthens at some future time?

Fair enough... I'll add them without the hyphen for now.

@sbc100 sbc100 merged commit 88fc9f0 into main Jul 17, 2021
@sbc100 sbc100 deleted the emdwp branch July 17, 2021 00:44
@kripken kripken mentioned this pull request Aug 2, 2021
Closed
sbc100 added a commit that referenced this pull request Aug 2, 2021
@sbc100
Remove em-dwp wrappers accidentally added in #14659
6ee02f1 
We decided to called this `emdwp` (without the dash) but somehow the PR
that landed still included the old ones.

Fixes: #14782
sbc100 added a commit that referenced this pull request Aug 2, 2021
@sbc100
Remove em-dwp wrappers accidentally added in #14659 (#14791)
16ff728 
We decided to called these `emdwp` (without the dash) but somehow the PR
that landed still included the old ones.

Fixes: #14782
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kripken kripken kripken approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should we create em wrapper scripts for other llvm tools (such as llvm-dwp and llvm-nm)?
2 participants
@sbc100 @kripken