WebGPU: Implement wgpuDeviceCreateComputePipelineAsync #22074
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kainino0x
approved these changes
Jun 11, 2024
|
Can we merge? |
|
Yes, I think this was the PR where I had to retry one of the steps that flaked and then I forgot about it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though upcoming WGPUFuture changes are going to impact
wgpuDeviceCreateComputePipelineAsync, this PR adds its support so that developers who need this now don't have to rely on hacks.Note that it was very similar to how
wgpuDeviceCreateRenderPipelineandwgpuDeviceCreateRenderPipelineAsyncare implemented.@kainino0x Please review.
Issue: http://b/332249405#comment52