Fix test browser configuring. #25258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
reviewed
Sep 11, 2025
| if not has_browser(): | ||
| return | ||
|
|
||
| if not EMTEST_BROWSER: |
There was a problem hiding this comment.
Seems odd that this code even runs at all then a non-browser test suite runs
|
I wonder why that windows CI bot doesn't failing on this? |
|
Maybe it unconditionally sets EMTEST_BROWSER? That was at least the reason my CI didn't fail on this - I set EMTEST_BROWSER on all runs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix two problems with test browser configuring refactor:
"No EMTEST_BROWSER set. Defaulting to google-chrome". Simplest way is to remove this print. There is already a printlogger.info('Launching browser: %s', str(browser_args))later down the line, so it should be fairly explicit what browser cmdline is being run.'"' not in EMTEST_BROWSERcheck, whenEMTEST_BROWSERwas stillNone.